Moti Asayag has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/39374/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java: Line 33: diskImage.getImageId())); Line 34: } Line 35: Line 36: if (asyncRetVal != null && asyncRetVal.isRequestCompleted()) { Line 37: if (!asyncRetVal.getSucceeded()) { is there a need to check the failure reason, just to make sure it is failed due to the expected error ? Line 38: cmd.setCommandStatus(CommandStatus.SUCCEEDED); Line 39: } else { Line 40: asyncRetVal = null; Line 41: } -- To view, visit https://gerrit.ovirt.org/39374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458143387f89a5d55bda5f1d4f9d44be4f7fb197 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
