Moti Asayag has posted comments on this change. Change subject: wip, engine : Remove Disk command using getVolumeInfo ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/39374/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommandCallback.java: Line 41: if (asyncRetVal != null && asyncRetVal.isRequestCompleted()) { Line 42: Object retVal = asyncRetVal.getReturnValue(); Line 43: if (retVal != null) { Line 44: DiskImage di = (DiskImage) retVal; Line 45: log.info("DiskImage retrieved " + di.getId()); please use the following supported notation: log.info("DiskImage retrieved '{}'", di.getId()); Line 46: log.info("DiskImage In command " + cmd.getDiskImage().getId()); Line 47: } Line 48: // if command failed execution we failed to retrieve disk image Line 49: // because it was deleted Line 42: Object retVal = asyncRetVal.getReturnValue(); Line 43: if (retVal != null) { Line 44: DiskImage di = (DiskImage) retVal; Line 45: log.info("DiskImage retrieved " + di.getId()); Line 46: log.info("DiskImage In command " + cmd.getDiskImage().getId()); same Line 47: } Line 48: // if command failed execution we failed to retrieve disk image Line 49: // because it was deleted Line 50: if (!asyncRetVal.getSucceeded()) { -- To view, visit https://gerrit.ovirt.org/39374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I458143387f89a5d55bda5f1d4f9d44be4f7fb197 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
