Martin Peřina has posted comments on this change. Change subject: aaa: builtin: manage-domains: convert to new parameters parser ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/39972/20/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 20: Line 21: private static String PROGRAM_NAME = System.getProperty("org.ovirt.engine.exttool.core.programName"); Line 22: private static String PACKAGE_NAME = System.getProperty("org.ovirt.engine.exttool.core.packageName"); Line 23: private static String PACKAGE_VERSION = System.getProperty("org.ovirt.engine.exttool.core.packageVersion"); Line 24: private static String PACKAGE_DISPLAY_NAME = System.getProperty("org.ovirt.engine.exttool.core.packageDisplayName"); I would also add final for all system property attributes Line 25: Line 26: public static void main(String... args) { Line 27: setupLogger(); Line 28: -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
