Alon Bar-Lev has posted comments on this change. Change subject: aaa: builtin: manage-domains: convert to new parameters parser ......................................................................
Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/39972/17/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 81: if(!util.isValidAction()) { Line 82: throw new ManageDomainsResult(ManageDomainsResultEnum.INVALID_ACTION, action); Line 83: } Line 84: Line 85: if ((Boolean)argMap.get("help")) { > how come --help is valid in this case? won't it return an error as in the a won't there be an error if --help is provider due to missing args? even if not now, if I add such in future? Line 86: System.out.format( Line 87: "usage: %s", Line 88: parser.getUsage().replace("@PROGRAM_NAME@", PROGRAM_NAME) Line 89: ); -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
