Martin Peřina has posted comments on this change. Change subject: aaa: builtin: manage-domains: convert to new parameters parser ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/39972/20/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java: Line 66: import org.slf4j.LoggerFactory; Line 67: Line 68: public class ManageDomains { Line 69: Line 70: private static String ENGINE_ETC = System.getProperty("org.ovirt.engine.exttool.core.engineEtc"); Please add final here Line 71: private final String WARNING_ABOUT_TO_DELETE_LAST_DOMAIN = Line 72: "WARNING: Domain %1$s is the last domain in the configuration. After deleting it you will have to either add another domain, or to use the internal admin user in order to login."; Line 73: private final String INFO_ABOUT_NOT_ADDING_PERMISSIONS = Line 74: "The domain %1$s has been added to the engine as an authentication source but no users from that domain" https://gerrit.ovirt.org/#/c/39972/20/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java: Line 56: StringUtils.join(parser.getErrors(), ", ") Line 57: ); Line 58: } Line 59: if (cmdArgs.size() < 1) { Line 60: throw new ManageDomainsResult( I would print help when no argument is entered same way as in previous version Line 61: ManageDomainsResultEnum.ARGUMENT_PARSING_ERROR, Line 62: "Please provide action." Line 63: ); Line 64: } -- To view, visit https://gerrit.ovirt.org/39972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I983b60824e31f279df0fe11c8adeb34b16f56e6a Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
