Martin Peřina has posted comments on this change. Change subject: engine: Add Upgrade host command ......................................................................
Patch Set 9: Code-Review+1 (2 comments) https://gerrit.ovirt.org/#/c/40462/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java: Line 89: rootCommand.setCommandStatus(CommandStatus.FAILED); Line 90: } Line 91: Line 92: break; Line 93: } > Please reformat ("case" should be indented more then "switch"): Sorry, I read you response later. If we had our formater set to this style, then it's OK. But IMO it's worth to change it (but, that's not part of this patch). Line 94: } Line 95: Line 96: /** Line 97: * Evaluates the progress of the {@code UpgradeHostInternalCommand} and updates root command status accordingly Line 121: case SUCCEEDED: Line 122: rootCommand.setCommandStatus(CommandStatus.SUCCEEDED); Line 123: return true; Line 124: } Line 125: } > Please reformat ("case" should be indented more then "switch"): Sorry, I read you response later. If we had our formater set to this style, then it's OK. But IMO it's worth to change it (but, that's not part of this patch). Line 126: Line 127: return false; Line 128: } Line 129: -- To view, visit https://gerrit.ovirt.org/40462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1447f3ebb5a7e3a67a8c68d449ae61e29f97fc Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
