Moti Asayag has posted comments on this change. Change subject: engine: Add Upgrade host command ......................................................................
Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/40462/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java: Line 57: CommandCoordinatorUtil.removeAllCommandsInHierarchy(cmdId); Line 58: } Line 59: Line 60: /** Line 61: * Evaluates the host status in regards to maintenance status: The host myst move to {@code VDSStatus.Maintenance} > s/mysy/must Done Line 62: * in order to proceed with the upgrade process. Line 63: * Line 64: * @param The Line 65: * child command IDs list to search if {@code MaintenanceNumberOfVdss} exists in it https://gerrit.ovirt.org/#/c/40462/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpgradeHostCommand.java: Line 62: cloneContext()); Line 63: Line 64: VdcReturnValueBase result; Line 65: try { Line 66: result = maintenanceCmd.get(); > I just wonder whether we should add "executeCommand" to cocoutils, rather t we can, this is a valid place were we could use that functionality and i was actually looking for the sync api when wrote his source code. Line 67: if (!result.getSucceeded()) { Line 68: propagateFailure(result); Line 69: return; Line 70: } -- To view, visit https://gerrit.ovirt.org/40462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1447f3ebb5a7e3a67a8c68d449ae61e29f97fc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
