Moti Asayag has posted comments on this change. Change subject: engine: Add Upgrade host command ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40462/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/HostUpgradeCallback.java: Line 97: rootCommand.setCommandStatus(CommandStatus.FAILED); Line 98: } Line 99: Line 100: break; Line 101: } > Please reformat: the engine formatter (located under config/engine-code-format.xml) contain the following rule: <setting id="org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch" value="false"/> It basically means that there is no indentation for the cases. So the above is how the engine formatter formats switch. If we wish to change it, we should first update the formatter and fix the code to match it. I'll switch the javadoc comments to // Line 102: } Line 103: Line 104: /** Line 105: * Evaluates the progress of the {@code UpgradeHostInternalCommand} and updates root command status accordingly -- To view, visit https://gerrit.ovirt.org/40462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a1447f3ebb5a7e3a67a8c68d449ae61e29f97fc Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
