ofri masad has posted comments on this change.
Change subject: core: QuotaManager Test - test 1
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
Line 151: assertFalse(EXPECTED_NO_AUDIT_LOG_MESSAGE, auditLogWritten);
Line 152: }
Line 153:
Line 154: @Test
Line 155: public void testValidateAndSetStorageQuota_1() throws Exception {
Parametrized Runner would yield many more tests than needed
Line 156: List<StorageQuotaValidationParameter> parameters = new
ArrayList<StorageQuotaValidationParameter>();
Line 157: parameters.add(new
StorageQuotaValidationParameter(STORAGE_QUOTA_GLOBAL_NOT_EXCEEDED,
DESTINATION_GUID, 1));
Line 158:
assertTrue(quotaManager.validateAndSetStorageQuota(storage_pool, parameters,
canDoActionMessages));
Line 159: assertEmptyCanDoActionMessage();
Line 290: private List<QuotaStorage> getQuotaStorages(long storageSize,
double storageSizeUsed) {
Line 291: ArrayList<QuotaStorage> quotaStorages = new
ArrayList<QuotaStorage>();
Line 292: quotaStorages.add(getQuotaStorage(UNLIMITED_STORAGE, 0));
Line 293: quotaStorages.add(getQuotaStorage(50, 5));
Line 294: quotaStorages.get(0).setStorageId(new Guid());
Done
Line 295: quotaStorages.get(1).setStorageId(new Guid());
Line 296: quotaStorages.add(getQuotaStorage(storageSize,
storageSizeUsed));
Line 297: return quotaStorages;
Line 298: }
Line 291: ArrayList<QuotaStorage> quotaStorages = new
ArrayList<QuotaStorage>();
Line 292: quotaStorages.add(getQuotaStorage(UNLIMITED_STORAGE, 0));
Line 293: quotaStorages.add(getQuotaStorage(50, 5));
Line 294: quotaStorages.get(0).setStorageId(new Guid());
Line 295: quotaStorages.get(1).setStorageId(new Guid());
Done
Line 296: quotaStorages.add(getQuotaStorage(storageSize,
storageSizeUsed));
Line 297: return quotaStorages;
Line 298: }
Line 299:
--
To view, visit http://gerrit.ovirt.org/8439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I374769dfcc4bb99de2e578d4267fb03484d9c63f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
