Allon Mureinik has posted comments on this change.
Change subject: core: QuotaManager Test - test1
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
I still have the same issue I had with this patch in the previous iteration.
If you disagree with this comment - please explain why, and lets discuss.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 268: }
Line 269:
newUsedSpecificStorageSize.get(quotaId).put(storageId,
Line 270:
quotaStorage.getStorageSizeGBUsage()
Line 271: +
desiredStorageSizeQuotaMap.get(quotaId).get(storageId));
Line 272: }
Not sure if this break is warranted or not, but removing it shouldn't be
coupled to this patch.
Line 273: }
Line 274: }
Line 275: if (!hasStorageId) {
Line 276:
canDoActionMessages.add(VdcBllMessages.ACTION_TYPE_FAILED_NO_QUOTA_SET_FOR_DOMAIN.toString());
--
To view, visit http://gerrit.ovirt.org/8439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I374769dfcc4bb99de2e578d4267fb03484d9c63f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
