Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 44: (4 comments) https://gerrit.ovirt.org/#/c/36119/44/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/LogoutSessionCommand.java: this probably belongs to the engine patch? Line 1: package org.ovirt.engine.core.bll.aaa; Line 2: Line 3: import java.util.Collections; Line 4: import java.util.List; https://gerrit.ovirt.org/#/c/36119/44/backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/web.xml: probably not belong to this patch Line 1: <?xml version="1.0"?> Line 2: <!-- Line 3: Copyright (c) 2014 Red Hat, Inc. Line 4: https://gerrit.ovirt.org/#/c/36119/44/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 259: # Line 260: # SSO Configuration Line 261: # Line 262: Line 263: SSO_WELCOME_URL=${ENGINE_URI}/ please add: SSO_URL=${ENGINE_URI}/sso not sure why leading / is required for URI. and use it in next definitions, example: SSO_QUERY_SERVICE=${SSO_URI}/... but as these services are not to be customized, only the prefix up to /sso is actually required for customization, the other components are part of the contract. Line 264: SSO_SWITCH_USER_URL=/${ENGINE_URI}/sso/login Line 265: SSO_ENABLE_EXTERNAL_AUTH=true Line 266: SSO_ENFORCE_NEGO=false Line 267: SSO_ACCEPT_BASIC_AUTH_HEADERS=true Line 266: SSO_ENFORCE_NEGO=false Line 267: SSO_ACCEPT_BASIC_AUTH_HEADERS=true Line 268: SSO_ALLOW_DISABLE_EXTERNAL_AUTH=true Line 269: SSO_ENABLE_BASIC_AUTH=false Line 270: SSO_QUERY_SERVICE=/${ENGINE_URI}/sso/query-service? please make sure you have new lines -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 44 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
