Alon Bar-Lev has posted comments on this change. Change subject: aaa : Add engine sso ......................................................................
Patch Set 49: (2 comments) https://gerrit.ovirt.org/#/c/36119/49/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 261: # Line 262: Line 263: SSO_WELCOME_URL=${ENGINE_URI} Line 264: SSO_URL=${ENGINE_URI}/sso Line 265: SSO_SWITCH_USER_URL=${SSO_URL}/login I am almost sure this also can be removed as /login is part of interface. Line 266: SSO_ENABLE_EXTERNAL_AUTH=true Line 267: SSO_ENFORCE_NEGO=false Line 268: SSO_ACCEPT_BASIC_AUTH_HEADERS=true Line 269: SSO_ALLOW_DISABLE_EXTERNAL_AUTH=true Line 267: SSO_ENFORCE_NEGO=false Line 268: SSO_ACCEPT_BASIC_AUTH_HEADERS=true Line 269: SSO_ALLOW_DISABLE_EXTERNAL_AUTH=true Line 270: SSO_ENABLE_BASIC_AUTH=false Line 271: SSO_QUERY_SERVICE=${SSO_URL}/query-service? new line please -- To view, visit https://gerrit.ovirt.org/36119 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4894fc12653027271b6abd4dd5313b10593703fa Gerrit-PatchSet: 49 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
