Moti Asayag has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/39756/10/packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql: Line 12: -- 3. All 1111 1111 Line 13: Line 14: CREATE TABLE cluster_features Line 15: ( Line 16: feature_id UUID NOT NULL, this should be aligned with the next field, so please either: feature_id, feature_name or id, name i think that the first option is more intuitive. Line 17: name VARCHAR(256) NOT NULL, Line 18: version VARCHAR(40), Line 19: category INTEGER NOT NULL, Line 20: description TEXT, Line 37: Line 38: CREATE TABLE supported_host_features Line 39: ( Line 40: host_id UUID NOT NULL, Line 41: feature VARCHAR(256) NOT NULL, s/feature/feature_name Line 42: CONSTRAINT PK_supported_host_features PRIMARY KEY (host_id, feature), Line 43: FOREIGN KEY (host_id) REFERENCES vds_static(vds_id) ON DELETE CASCADE Line 44: ) ; Line 45: Line 42: CONSTRAINT PK_supported_host_features PRIMARY KEY (host_id, feature), Line 43: FOREIGN KEY (host_id) REFERENCES vds_static(vds_id) ON DELETE CASCADE Line 44: ) ; Line 45: Line 46: CREATE UNIQUE INDEX IDX_supported_host_features ON supported_host_features(host_id, feature); Eli, isn't this index redundant since it is already covered by the PK from line 42 ? Line 47: -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
