Ramesh N has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 12: (7 comments) https://gerrit.ovirt.org/#/c/39756/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java: Line 749: Line 750: public ClusterFeatureDao getClusterFeatureDao() { Line 751: return getDbFacade().getClusterFeatureDao(); Line 752: } Line 753: > I'd rather not introducing this as a method, instead we should using inject In fact i have used injection in all the places. I don't require this method here. Line 754: public SupportedHostFeatureDao getSupportedHostFeatureDao() { Line 755: return getDbFacade().getSupportedHostFeatureDao(); Line 756: } Line 757: https://gerrit.ovirt.org/#/c/39756/12/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/SupportedHostFeatureDaoImpl.java: Line 27: } Line 28: Line 29: private MapSqlParameterSource createSupportedHostFeatureParameterMapper(String feature, Guid vdsId) { Line 30: return getCustomMapSqlParameterSource() Line 31: .addValue("vds_id", vdsId) > wasn't this changed to host_id ? Done Line 32: .addValue("feature_name", feature); Line 33: } Line 34: Line 35: @Override https://gerrit.ovirt.org/#/c/39756/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 657: vds > s/vds/host Done https://gerrit.ovirt.org/#/c/39756/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 711: updateAdditionalFeatures(vds, xmlRpcStruct); Line 712: } Line 713: Line 714: private static void updateAdditionalFeatures(VDS vds, Map<String, Object> xmlRpcStruct) { Line 715: String[] addtionalFeaturesSupportedByHost = AssignStringArrayValue(xmlRpcStruct, VdsProperties.ADDITIONAL_FEATURES); > should be format (exceeds 120 chars) Done Line 716: if(addtionalFeaturesSupportedByHost != null){ Line 717: for (String feature : addtionalFeaturesSupportedByHost) { Line 718: vds.getAdditionalFeatures().add(feature); Line 719: } Line 712: } Line 713: Line 714: private static void updateAdditionalFeatures(VDS vds, Map<String, Object> xmlRpcStruct) { Line 715: String[] addtionalFeaturesSupportedByHost = AssignStringArrayValue(xmlRpcStruct, VdsProperties.ADDITIONAL_FEATURES); Line 716: if(addtionalFeaturesSupportedByHost != null){ > please format: missing a space between if and ( and missing a space after t Done Line 717: for (String feature : addtionalFeaturesSupportedByHost) { Line 718: vds.getAdditionalFeatures().add(feature); Line 719: } Line 720: } https://gerrit.ovirt.org/#/c/39756/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java: Line 368: public static final String DST_QEMU = "dstqemu"; Line 369: public static final String MIGRATION_DOWNTIME = "downtime"; Line 370: public static final String AUTO_CONVERGE = "autoConverge"; Line 371: public static final String MIGRATE_COMPRESSED = "compressed"; Line 372: public static final String ADDITIONAL_FEATURES = "additionalFeatures"; > i guess that in the future we'll have to decide the name of it according to This field is getting added to VDSM API with the patch https://gerrit.ovirt.org/#/c/39324/. It will have the list of addtional features supported by VDSM. Line 373: // storage domains Line 374: public static final String code = "code"; Line 375: public static final String lastCheck = "lastCheck"; Line 376: public static final String delay = "delay"; https://gerrit.ovirt.org/#/c/39756/12/packaging/dbscripts/cluster_features_sp.sql File packaging/dbscripts/cluster_features_sp.sql: Line 109: GetSupportedHostFeaturesByVdsId > s/GetSupportedHostFeaturesByVdsId/GetSupportedHostFeaturesByHostId Done -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
