Ramesh N has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/39756/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdditionalClusterFeature.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AdditionalClusterFeature.java: Line 11: Line 12: private static final long serialVersionUID = -8387930346405670858L; Line 13: private Guid id; Line 14: private String name; Line 15: private String version; > Can we use 'Version' class instead of String? Done Line 16: private String description; Line 17: private ApplicationMode category; Line 18: Line 19: public AdditionalClusterFeature() { https://gerrit.ovirt.org/#/c/39756/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 658: VdsDynamicDAO vdsDynamicDao = DbFacade.getInstance().getVdsDynamicDao(); Line 659: Set<String> supportedHostFeatures = vdsDynamicDao.getSupportedHostFeaturesByVdsId(vdsId); Line 660: vds.getSupportedFeatures().removeAll(supportedHostFeatures); Line 661: if (!vds.getSupportedFeatures().isEmpty()) { Line 662: vdsDynamicDao.addAllSupportedHostFeature(vdsId, vds.getSupportedFeatures()); > What about remove? Will do that Line 663: } Line 664: } Line 665: Line 666: private HostNetworkTopologyPersister getHostNetworkTopologyPersister() { https://gerrit.ovirt.org/#/c/39756/9/packaging/dbscripts/cluster_features_sp.sql File packaging/dbscripts/cluster_features_sp.sql: Line 43: -- 3. All 1111 1111 Line 44: -- Line 45: -- Now suppose the value of input category is Gluster - 2 (0000 0010), then Line 46: -- set of features would include all the roles with category values either 2 or 255 Line 47: -- Now start doing bitwise AND for valid category values 1, 2 and 255 with input category. > TWS Done Line 48: -- Only bitwise AND with 2 and 255 would result in a value greater Line 49: -- than ZERO (0) and applicable set of features are identified. Line 50: -- Line 51: -- 1 & 2 (0000 0001 & 0000 0010) = 0000 0000 = 0 Features with this category would NOT be listed -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
