Eli Mesika has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 8: (4 comments) https://gerrit.ovirt.org/#/c/39756/8/packaging/dbscripts/cluster_features_sp.sql File packaging/dbscripts/cluster_features_sp.sql: Line 1: /* ---------------------------------------------------------------- Line 2: Stored procedures for database operations on Cluster Features Line 3: related tables: cluster_features, supported_cluster_features, supported_host_features Line 4: ----------------------------------------------------------------*/ Line 5: Create or replace function InsertClusterFeature(v_feature_id UUID, General : Please use a 4 spaces instead of TABs all over this file Line 6: v_feature VARCHAR(256), Line 7: v_version VARCHAR(40), Line 8: v_app_mode INTEGER, Line 9: v_description TEXT) Line 50: -- than ZERO (0) and applicable set of roles are identified. Line 51: -- Line 52: -- 1 & 2 (0000 0001 & 0000 0010) = 0000 0000 = 0 Roles with this app_mode would NOT be listed Line 53: -- 2 & 2 (0000 0010 & 0000 0010) = 0000 0010 = 2 > 0 Roles with this app_mode would be listed Line 54: -- 255 & 2 (1111 1111 & 0000 0010) = 0000 0010 = 2 > 0 Roles with this app_mode would be listed please add a newline here Line 55: Create or replace FUNCTION GetClusterFeaturesByVersionAndAppMode(v_version VARCHAR(256), v_app_mode INTEGER) Line 56: RETURNS SETOF supported_host_features STABLE Line 57: AS $procedure$ Line 58: BEGIN https://gerrit.ovirt.org/#/c/39756/8/packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql: Line 1: -- ---------------------------------------------------------------------- General : TABs => spaces Line 2: -- tables cluster_features, supported_cluster_features and supported_host_features Line 3: -- Maintains the list of features which are supported by Engine. This is on top of the Line 4: -- standard cluster compatibility version check. Line 5: -- ---------------------------------------------------------------------- Line 35: CREATE UNIQUE INDEX IDX_supported_cluster_features ON supported_cluster_features(cluster_id, feature_id); Line 36: Line 37: CREATE TABLE supported_host_features Line 38: ( Line 39: vds_id UUID NOT NULL, isn't it more right to use the term host_id instead of the old vds ??? (the same as we use cluster and not vds_group) ??? Line 40: feature VARCHAR(256) NOT NULL, Line 41: CONSTRAINT PK_supported_host_features PRIMARY KEY (vds_id, feature), Line 42: FOREIGN KEY (vds_id) REFERENCES vds_static(vds_id) ON DELETE CASCADE Line 43: ) ; -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
