Kanagaraj M has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 8: (8 comments) https://gerrit.ovirt.org/#/c/39756/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByVersionAndAppModeQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetClusterFeaturesByVersionAndAppModeQuery.java: Line 8: GetClusterFeaturesByVersionAndAppModeQuery GetClusterFeaturesByVersionAndCategoryQuery Line 17: getClusterFeaturesForVersionAndAppMode getClusterFeaturesForVersionAndCategory https://gerrit.ovirt.org/#/c/39756/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 531: && ObjectUtils.objectsEqual(maintenanceReasonRequired, other.maintenanceReasonRequired) Duplicate https://gerrit.ovirt.org/#/c/39756/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterFeaturesByVersionAndAppModeParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetClusterFeaturesByVersionAndAppModeParameters.java: Line 7: GetClusterFeaturesByVersionAndAppModeParameters GetClusterFeaturesByVersionAndCategoryParameters https://gerrit.ovirt.org/#/c/39756/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java: Line 133: getSupportedHostFeaturesByVdsId This should go to VdsDynamic https://gerrit.ovirt.org/#/c/39756/8/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: Line 266: .addValue("supported_rng_sources", VmRngDevice.sourcesToCsv(vds.getSupportedRngSources())) Line 267: .addValue("supported_emulated_machines", vds.getSupportedEmulatedMachines()) Line 268: .addValue("is_live_snapshot_supported", vds.getLiveSnapshotSupport()) Line 269: .addValue("is_live_merge_supported", vds.getLiveMergeSupport()) Line 270: .addValue("maintenance_reason", vds.getMaintenanceReason()); Exclude this file Line 271: return parameterSource; Line 272: } Line 273: Line 274: @Override https://gerrit.ovirt.org/#/c/39756/8/packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql File packaging/dbscripts/upgrade/03_06_1290_add_cluster_features_table.sql: Line 10: -- 1. VirtOnly 0000 0001 : -- 2. GlusterOnly 0000 0010 : -- 3. AllModes 1111 1111 -- 1. Virt 0000 0001 -- 2. Gluster 0000 0010 -- 3. All 1111 1111 Line 18: app_mode you could call this as 'category' -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
