Michael Kublin has posted comments on this change. Change subject: core: Validate maximum number of hosts in DC.(#771699) ......................................................................
Patch Set 4: You started to rewrite a logic, but for some reason you are trying to make a half work, it is means that after your patch I will need a change a new one which will fix all problems. I don't see reason for half work. It is obvious that we don't need RemoveVdsSpmId command, and it is obvious from your code - remove it. It is obvious that you are trying to play with compensation , so the patch should fix all problems with compensation at commands that you are touching. You can not left a code half - dead and half - alive, such code is usually full - dead -- To view, visit http://gerrit.ovirt.org/8321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
