Liron Aravot has posted comments on this change.

Change subject: core: Validate maximum number of hosts in DC.(#771699)
......................................................................


Patch Set 3: (1 inline comment)

dao test will be added, answered inline comment.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
Line 58:     @Override
Line 59:     protected void executeCommand() {
Line 60:         // according to shaharf the first id is 1
Line 61:         int selectedId = 1;
Line 62:         List<Integer> map = LinqUtils.foreach(vds_spm_id_mapList, new 
Function<vds_spm_id_map, Integer>() {
not my name..changed by rebase i guess, will rename back.
Line 63:             @Override
Line 64:             public Integer eval(vds_spm_id_map vds_spm_id_map) {
Line 65:                 return vds_spm_id_map.getvds_spm_id();
Line 66:             }


--
To view, visit http://gerrit.ovirt.org/8321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to