Allon Mureinik has posted comments on this change. Change subject: core: Validate maximum number of hosts in DC.(#771699) ......................................................................
Patch Set 4: Yair: I think we have a missunderstanding. If a patch changes DAOs but does not test them, it should be given -1, even if the rest of it is perfect. I do agree that the patch should be coupled to the DAO code change (regardless if it's changing, removing, or adding a new method). I do /not/ agree that you should have two patches - one for the dao changes (and their tests), and another one, on top of the first, with the bll changes. In this paradigm, the first patch on it's own is useless - it introduces code (albeit well tested code) that is dead - it is never used, and does not contribute functionality to the system as a whole. The upside I do see for this paradigm is easier reviewing, but I submit that the following BLL patch should be highly difficult to review in its own right to warrant this paradigm. Does this make more sense now? (i.e. - was I more successful in making my point? whether or not I convinced you is a different issue :-)) -- To view, visit http://gerrit.ovirt.org/8321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375400f3e12e3e0452053dea12ac6e28bc0ff61 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
