Kanagaraj M has posted comments on this change. Change subject: webadmin,engine : allow user to set tuned profile ......................................................................
Patch Set 6: (2 comments) pls add gluster prefix to the variables https://gerrit.ovirt.org/#/c/39769/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 439: } Line 440: Line 441: private void setVisibilities() { Line 442: tunedProfileEditor.setVisible(ApplicationModeHelper.isModeSupported(ApplicationMode.GlusterOnly)); Line 443: } this can be done in the model itself Line 444: Line 445: @Override Line 446: protected void populateTabMap() { Line 447: getTabNameMapping().put(TabName.GENERAL_TAB, this.generalTab); https://gerrit.ovirt.org/#/c/39769/6/packaging/dbscripts/upgrade/03_06_1250_add_tuned_profile_column_to_vds_groups.sql File packaging/dbscripts/upgrade/03_06_1250_add_tuned_profile_column_to_vds_groups.sql: Line 1: select fn_db_add_column('vds_groups', 'tuned_profile', 'VARCHAR(50)'); Is this going to applicable only for cluster? If yes, you may want to add a gluster prefix to it. -- To view, visit https://gerrit.ovirt.org/39769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef3f957dfcc40cef8de541898fbc08d698d0ce7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
