anmolbabu has posted comments on this change. Change subject: webadmin,engine : allow user to set tuned profile ......................................................................
Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/39769/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 480: VDSGroup vdsGroup = DbFacade.getInstance().getVdsGroupDao().get( Line 481: _vds.getVdsGroupId() Line 482: ); Line 483: _parser.cliEnvironmentSet( Line 484: TuneEnv.TUNED_PROFILE, > please remove indent Done Line 485: vdsGroup.getTunedProfile() Line 486: ); Line 487: return true; Line 488: }}, Line 481: _vds.getVdsGroupId() Line 482: ); Line 483: _parser.cliEnvironmentSet( Line 484: TuneEnv.TUNED_PROFILE, Line 485: vdsGroup.getTunedProfile() > can we drop the vdsGroup temp var? Now it will be needed to check gluster enabled Line 486: ); Line 487: return true; Line 488: }}, Line 489: new Callable<Boolean>() { public Boolean call() throws Exception { https://gerrit.ovirt.org/#/c/39769/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java: Line 1172: "MYTMP=\"$(TMPDIR=\"${OVIRT_TMPDIR}\" mktemp -d -t ovirt-XXXXXXXXXX)\"; " + Line 1173: "trap \"chmod -R u+rwX \\\"${MYTMP}\\\" > /dev/null 2>&1; rm -fr \\\"${MYTMP}\\\" > /dev/null 2>&1\" 0; " + Line 1174: "tar --warning=no-timestamp -C \"${MYTMP}\" -x && " + Line 1175: "@ENVIRONMENT@ \"${MYTMP}\"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True" Line 1176: ) > why? Sorry this came as a result of eclipse save preference will undo it Line 1177: BootstrapCommand, Line 1178: Line 1179: @TypeConverterAttribute(Integer.class) Line 1180: @DefaultValueAttribute("10000") Line 2045: MaxWriteIopsUpperBoundQosValue, Line 2046: Line 2047: /** Line 2048: * Defines the number of history values storable by the engine for cpu/network/memory usage of a VM Line 2049: */ > why? Sorry this came as a result of eclipse save preference will undo it Line 2050: @TypeConverterAttribute(Integer.class) Line 2051: @DefaultValueAttribute("40") Line 2052: UsageHistoryLimit, Line 2053: -- To view, visit https://gerrit.ovirt.org/39769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef3f957dfcc40cef8de541898fbc08d698d0ce7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
