anmolbabu has posted comments on this change. Change subject: webadmin,engine : allow user to set tuned profile ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/39769/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 482: ); Line 483: if(vdsGroup.supportsGlusterService()) { Line 484: _parser.cliEnvironmentSet( Line 485: TuneEnv.TUNED_PROFILE, Line 486: vdsGroup.getGlusterTunedProfile() > what happens if this value is empty? Done Line 487: ); Line 488: } Line 489: return true; Line 490: }}, https://gerrit.ovirt.org/#/c/39769/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 886: } Line 887: glusterTunedProfile.setItems(glusterTunedProfiles); Line 888: } Line 889: })); Line 890: glusterTunedProfile.setIsAvailable(glusterTunedProfile.getItems().size() > 0 && ApplicationModeHelper.isModeSupported(ApplicationMode.GlusterOnly)); > ApplicationM Yeah So, upstream gluster-specific profiles aren't there. Only rhs has them. Prior to this patch ovirt-host-deploy used to default it to rhs-virtualization profile it used to silently fail upstream as there's no such profile exposed by upstream. Line 891: } Line 892: Line 893: public void init(final boolean isEdit) { Line 894: setIsEdit(isEdit); -- To view, visit https://gerrit.ovirt.org/39769 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ef3f957dfcc40cef8de541898fbc08d698d0ce7 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
