Yair Zaslavsky has posted comments on this change. Change subject: engine: Refresh gluster data periodically ......................................................................
Patch Set 9: Regarding MassOperationsDao - yes, let's add removeAll as well. The idea is to make sure we're using a single DB connection. This is more important than the actual construction of the collection that will be passed to it. Regarding AuditLogType - maybe instead of XXX_FROM_CLI change to XXX_FROM_GLUSTER_CLI? Besides that, all the rest of your comments are fine. -- To view, visit http://gerrit.ovirt.org/7288 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b61eb6e93105e46e2706eac1d94bc10717224c2 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
