Oved Ourfali has posted comments on this change. Change subject: engine: add_gluster_3_7_feature_support_flag to vds_group ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39756/1/packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql File packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql: Line 1: select fn_db_add_column('vds_groups', 'is_gluster_3_7_features_supported', 'BOOLEAN'); Line 2: select fn_db_add_column('vds_dynamic', 'is_gluster_3_7_features_supported', 'BOOLEAN'); > I knew it doesn't look nice to have these fields here, but unfortunately we You can have a new table with three columns: vds_group_id feature enabled It will specify what clusters require specific features. When activating a host, you'll get from VDSM whether these features are supported or not, and if they are it will activate the host properly. If not, it will fail, with relevant errors. You should do it like mentioned above, or in another "generic" way you can propose, but not something specific to a specific version. -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
