Ramesh N has posted comments on this change. Change subject: engine: add_gluster_3_7_feature_support_flag to vds_group ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39756/1/packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql File packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql: Line 1: select fn_db_add_column('vds_groups', 'is_gluster_3_7_features_supported', 'BOOLEAN'); Line 2: select fn_db_add_column('vds_dynamic', 'is_gluster_3_7_features_supported', 'BOOLEAN'); > Why do we have to add such columns to those tables I knew it doesn't look nice to have these fields here, but unfortunately we could not find any other better way to solve the problem. Let me explain u the problem here. Currently all gluster related new features are supported in ovirt 3.6 compatibility. But we want to backport all those patches to branch ovirt-3.5-gluster which is based on ovirt-3.5. So we will have two variations of 3.5 cluster. Some 3.5 cluster will have standard 3.5 features. Some will have standard 3.5 features + new gluster37 features which are supported in 3.6(GEO Rep, Snapshost, diskprovisioning) etc. This helps to differentiate vds which supports cluster level 3.5 with extra support for advanced gluster features like GEO REP from the standard 3.5 vds. I hope it won't be repeated in future. Let me know if u have different approach to solve this issue. Note: All this mess is created because we have released red hat storage server with vdsm based on rhevm-3.5 which already supports cluster level 3.5. -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
