Eli Mesika has posted comments on this change. Change subject: engine: add_gluster_3_7_feature_support_flag to vds_group ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39756/1/packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql File packaging/dbscripts/upgrade/03_06_1170_add_gluster_3_7_feature_support_flag_to_vds_group.sql: Line 1: select fn_db_add_column('vds_groups', 'is_gluster_3_7_features_supported', 'BOOLEAN'); Line 2: select fn_db_add_column('vds_dynamic', 'is_gluster_3_7_features_supported', 'BOOLEAN'); Why do we have to add such columns to those tables Imagine what we will have in future How many is_gluster_x_supported will we have in future? Don't we have nicer way to get this information ? Please consider a different approach -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
