Alona Kaplan has posted comments on this change. Change subject: engine: calling CollectVdsNetworkData after vm state changed to up ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38261/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 598: if (refreshHostNetworkDataNeeded) { Line 599: ThreadPoolUtil.execute(new Runnable() { Line 600: @Override Line 601: public void run() { Line 602: VDS vds = DbFacade.getInstance().getVdsDao().get(getVdsId()); > is there a need to fetch the host again ? it is cached from time to time in Done Line 603: ResourceManager.getInstance().runVdsCommand(VDSCommandType.CollectVdsNetworkData, Line 604: new CollectHostNetworkDataVdsCommandParameters(vds, Line 605: Collections.<VdsNetworkInterface> emptyList())); Line 606: } Line 602: VDS vds = DbFacade.getInstance().getVdsDao().get(getVdsId()); Line 603: ResourceManager.getInstance().runVdsCommand(VDSCommandType.CollectVdsNetworkData, Line 604: new CollectHostNetworkDataVdsCommandParameters(vds, Line 605: Collections.<VdsNetworkInterface> emptyList())); Line 606: } > before this thread ends, you must set refreshHostNetworkDataNeeded to false Done Line 607: }); Line 608: } Line 609: } Line 610: -- To view, visit https://gerrit.ovirt.org/38261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
