Moti Asayag has posted comments on this change. Change subject: engine: calling CollectVdsNetworkData after vm state changed to up ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38261/7/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 593: Line 594: refreshHostNetworkDataNeeded = !vfs.isEmpty(); Line 595: } Line 596: Line 597: public void refreshHostNetworksIfNeeded() { we need to verify this is not over-used. The CollectVdsNetwork is considered to be "heavy" action. I'd be happier to see that instead querying vdsm about the host capabilities, that vdsm is capable to send an event notifying the engine that a specific vf became available. Line 598: if (refreshHostNetworkDataNeeded) { Line 599: ThreadPoolUtil.execute(new Runnable() { Line 600: @Override Line 601: public void run() { -- To view, visit https://gerrit.ovirt.org/38261 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
