Alona Kaplan has posted comments on this change.

Change subject: engine: calling CollectVdsNetworkData after vm state changed to 
up
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38261/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java:

Line 584:     public void succeededToRunVm(Guid vmId) {
Line 585:         mUnrespondedAttempts.set(0);
Line 586:         ResourceManager.getInstance().succededToRunVm(vmId, 
getVdsId());
Line 587: 
Line 588:         refreshHostNetworksIfNeeded(vmId);
> this should be called once per monitoring cycle (and not per vm)  and in a 
Done
Line 589:     }
Line 590: 
Line 591:     private void refreshHostNetworksIfNeeded(final Guid vmId) {
Line 592:         VDS vds = DbFacade.getInstance().getVdsDao().get(getVdsId());


-- 
To view, visit https://gerrit.ovirt.org/38261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id89c51e738b75af0492e3b314a261b6beba7ee76
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to