Alona Kaplan has posted comments on this change.

Change subject: engine: passing vf's params of vm create
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/38119/5/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java:

Line 710:         specParams.put(VdsProperties.MAC_ADDR, 
vmInterface.getMacAddress());
Line 711: 
Line 712:         VnicProfile vnicProfile = 
DbFacade.getInstance().getVnicProfileDao().get(vmInterface.getVnicProfileId());
Line 713:         Network network = 
DbFacade.getInstance().getNetworkDao().get(vnicProfile.getNetworkId());
Line 714:         if (NetworkUtils.isVlan(network)) {
> is it allowed ? vlan + VF ?
yes
Line 715:             specParams.put(VdsProperties.VLAN_ID, 
network.getVlanId());
Line 716:         }
Line 717:         struct.put(VdsProperties.SpecParams, specParams);
Line 718:     }


-- 
To view, visit https://gerrit.ovirt.org/38119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a033cfa8468a047c34dfe821f9f2dc14c4c0598
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to