Piotr Kliczewski has posted comments on this change. Change subject: engine: Added username to geo-rep commands ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39485/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 383: StatusOnlyReturnForXmlRpc glusterVolumeGeoRepConfigReset(String volumeName, Line 384: String slaveHost, Line 385: String slaveVolumeName, Line 386: String configKey, Line 387: String slaveUserName); > Just a thought can we have consistent names? In parameters we use username so it would be good to have naming consistent across this change. You can keep parameter key as required by vdsm. Line 388: Line 389: GlusterVolumeGeoRepConfigListXmlRpc glusterVolumeGeoRepConfigList(String volumeName, Line 390: String slaveHost, Line 391: String slaveVolumeName, -- To view, visit https://gerrit.ovirt.org/39485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
