Sahina Bose has posted comments on this change. Change subject: engine: Added username to geo-rep commands ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39485/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ResetDefaultGeoRepConfigCommand.java: Line 27: session.getMasterVolumeName(), Line 28: session.getSlaveHostName(), Line 29: session.getSlaveVolumeName(), Line 30: getParameters().getConfigKey(), Line 31: null, > :) I meant why not have separate constructor for this :D How do you mean? Could you explain? we do have 2 constructors - (Guid volumeId, Guid sessionId, String configKey, String configValue) and (Guid volumeId, Guid sessionId, String configKey, String configValue, String userName) Line 32: session.getUserName())); Line 33: setSucceeded(returnValue.getSucceeded()); Line 34: if (!getSucceeded()) { Line 35: handleVdsError(AuditLogType.GLUSTER_GEOREP_CONFIG_SET_DEFAULT_FAILED, returnValue.getVdsError() -- To view, visit https://gerrit.ovirt.org/39485 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fcdc7c29abb88916eacc048f2708ea68540134a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
