Moti Asayag has posted comments on this change. Change subject: core: add max memory for scheduling VMs as a calculated field to VDS ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1133: <xs:element name="root_password" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1134: <xs:element name="statistics" type="Statistics" minOccurs="0" maxOccurs="1"/> Line 1135: <xs:element ref="cpu" minOccurs="0" maxOccurs="1"/> Line 1136: <xs:element name="memory" type="xs:long" minOccurs="0"/> Line 1137: <xs:element name="maxSchedulingMemory" type="xs:long" minOccurs="0"/> it seems that the name does not comply with the naming convention. change to max_scheduling_memory Line 1138: <xs:element name="summary" type="VmSummary" minOccurs="0" maxOccurs="1"/> Line 1139: <xs:element name="override_iptables" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1140: <!-- when installing a host, optionally reboot the host --> Line 1141: <xs:element name="reboot_after_installation" type="xs:boolean" minOccurs="0"/> -- To view, visit http://gerrit.ovirt.org/7825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cb338f79682bdc550c4cc6e0667ba1fea50a9c6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
