Tomas Jelinek has posted comments on this change.
Change subject: core: add max memory for scheduling VMs as a calculated field
to VDS
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
Line 150: <include
name="common/businessentities/RepoFileMetaData.java" />
Line 151: <include
name="common/businessentities/FileTypeExtension.java" />
Line 152: <include
name="common/businessentities/HostFreeGuestMemoryCalculator.java" />
Line 153: <include
name="common/businessentities/SimpleHostFreeGuestMemoryCalculator.java" />
Line 154:
Are this two classes actually used somewhere? And are they defined somewhere? I
can not even find the files :)
Line 155:
Line 156: <include name="common/job/*.java" />
Line 157:
Line 158: <!-- Quota -->
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java
Line 479:
Line 480: public Float getMaxSchedulingMemory() {
Line 481: return maxSchedulingMemory;
Line 482: }
Line 483:
Is this actually needed?
Line 484: private boolean hasAnyAlert;
Line 485:
Line 486: public boolean getHasAnyAlert()
Line 487: {
--
To view, visit http://gerrit.ovirt.org/7825
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cb338f79682bdc550c4cc6e0667ba1fea50a9c6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
