Eli Mesika has posted comments on this change.

Change subject: core: add max memory for scheduling VMs as a calculated field 
to VDS
......................................................................


Patch Set 6: Looks good to me, approved

(1 inline comment)

please fix comment before merging

....................................................
Commit Message
Line 12: future scheduling policies, which means the actual number can be lower.
Line 13: 
Line 14: The calculation is:
Line 15: 
Line 16:      (getmax_vds_memory_over_commit() * getphysical_mem_mb() / 100.0f)
please add a '-' sign to the end of this line
Line 17:                         -
Line 18:      (getmem_commited() + getreserved_mem())
Line 19: 
Line 20: Field is added to GUI as Mb and to REST as bytes (traditionally for all


--
To view, visit http://gerrit.ovirt.org/7825
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8cb338f79682bdc550c4cc6e0667ba1fea50a9c6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to