Dhandapani Gopal has posted comments on this change.

Change subject: engine: Get Gluster Servers query
......................................................................


Patch Set 7:

"Hi,
I don't understand the usage of ssh key fingerprint in this code.
If you don't check fingerprint when connecting, what exactly do you do with the 
fingerprint map?
Isn't this behaviour is duplicate of [1]?
Alon"

The Import cluster feature has two dialog. 
1. In first dialog, the user will provide any one of the server name in the 
cluster. Using the server name I will fetch the fingerprint of the server and 
show it to the user. For this purpose we are invoking the query [1].
If the user verifies this fingerprint, then he will provide password of the 
server. Using this credentials I will connect to server and run the "gluster 
peer status" command over SSH. This command will return the list of servers in 
the cluster. For all server, we will fetch the fingerprint and send back to the 
UI. For this purpose we are invoking the query[2]. In second dialog UI will 
display all the servers with fingerprint. Once user approves all the servers 
then will add all the servers to the engine.

[1] http://gerrit.ovirt.org/#/c/7034/
[2] http://gerrit.ovirt.org/#/c/7584/

Pls refer the mock up screens which sent by kmayi...@redhat.com

--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to