Omer Frenkel has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 33: * Since, the importing cluster haven't been bootstarped yet,
Line 34: * we are running the gluster peer status command via ssh.
Line 35: *
Line 36: */
Line 37: public class GetGlusterServersQuery<P extends
GlusterServersQueryParameters> extends GlusterQueriesCommandBase<P> {
all public methods here are public because of unit tests?
Line 38:
Line 39: private static final String PEER = "peer";
Line 40: private static final String HOST_NAME = "hostname";
Line 41: private static final String STATE = "state";
Line 160: }
Line 161:
Line 162: private void parseHostName(NodeList listOfPeers) {
Line 163: for (int i=0; i < listOfPeers.getLength(); i++) {
Line 164: Node firstPeer = listOfPeers.item(i);
it might be personal preference, but its more common to use:
for (Node firstPeer : listOfPeers)
Line 165: if(firstPeer.getNodeType() == Node.ELEMENT_NODE){
Line 166: Element firstHostElement = (Element)firstPeer;
Line 167: int state = getIntValue(firstHostElement, STATE);
Line 168: // Add the server only if the state is 3
Line 198: }
Line 199:
Line 200: @Override
Line 201: public void addMessage(String message) {
Line 202: if (!message.toString().equals("")) {
should be: if (StringUtils.isNotEmpty(message)) {...}
will also cover null message
Line 203: glusterServersXml = message.toString();
Line 204: }
Line 205: }
Line 206:
Line 199:
Line 200: @Override
Line 201: public void addMessage(String message) {
Line 202: if (!message.toString().equals("")) {
Line 203: glusterServersXml = message.toString();
no need to do .toString() on String
Line 204: }
Line 205: }
Line 206:
Line 207: @Override
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
