Piotr Kliczewski has posted comments on this change. Change subject: engine : VDS command for creating geo-rep session ......................................................................
Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/UpdateGlusterGeoRepKeysVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/UpdateGlusterGeoRepKeysVDSCommand.java: Line 20: protected void executeVdsBrokerCommand() { Line 21: UpdateGlusterGeoRepKeysVDSParameters parameters = getParameters(); Line 22: status = Line 23: getBroker().glusterGeoRepKeysUpdate(parameters.getRemoteUserName(), Line 24: new ArrayList<>(parameters.getGeoRepPubKeys())); Why you create new List here? getGeoRepPubKeys returns a list already. Line 25: proceedProxyReturnValue(); Line 26: } Line 27: -- To view, visit https://gerrit.ovirt.org/29833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
