Sahina Bose has posted comments on this change. Change subject: engine : VDS command for creating geo-rep session ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/UpdateGlusterGeoRepKeysVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/UpdateGlusterGeoRepKeysVDSParameters.java: Line 18: super(vdsId); Line 19: this.geoRepPubKeys = geoRepPubKeys; Line 20: } Line 21: Line 22: public UpdateGlusterGeoRepKeysVDSParameters(Guid vdsId, String remoteUserName, List<String> geoRepPubKeys) { Can you move the remoteUserName as third argument. You could call this(vdsId, geoRepPubKeys) inside this constructor Line 23: super(vdsId); Line 24: this.remoteUserName = remoteUserName; Line 25: this.geoRepPubKeys = geoRepPubKeys; Line 26: } https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1203: Change to use remoteUserName as second parameter to this method https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 282: StatusOnlyReturnForXmlRpc change to remoteUserName as second paramater -- To view, visit https://gerrit.ovirt.org/29833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
