anmolbabu has posted comments on this change. Change subject: engine : VDS command for creating geo-rep session ......................................................................
Patch Set 23: (4 comments) https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/UpdateGlusterGeoRepKeysVDSParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/UpdateGlusterGeoRepKeysVDSParameters.java: Line 18: super(vdsId); Line 19: this.geoRepPubKeys = geoRepPubKeys; Line 20: } Line 21: Line 22: public UpdateGlusterGeoRepKeysVDSParameters(Guid vdsId, String remoteUserName, List<String> geoRepPubKeys) { > Can you move the remoteUserName as third argument. Done Line 23: super(vdsId); Line 24: this.remoteUserName = remoteUserName; Line 25: this.geoRepPubKeys = geoRepPubKeys; Line 26: } https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/UpdateGlusterGeoRepKeysVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/UpdateGlusterGeoRepKeysVDSCommand.java: Line 20: protected void executeVdsBrokerCommand() { Line 21: UpdateGlusterGeoRepKeysVDSParameters parameters = getParameters(); Line 22: status = Line 23: getBroker().glusterGeoRepKeysUpdate(parameters.getRemoteUserName(), Line 24: new ArrayList<>(parameters.getGeoRepPubKeys())); > Why you create new List here? getGeoRepPubKeys returns a list already. Done Line 25: proceedProxyReturnValue(); Line 26: } Line 27: https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1199: return new GlusterHostsPubKeyReturnForXmlRpc(response); Line 1200: } Line 1201: Line 1202: @Override Line 1203: public StatusOnlyReturnForXmlRpc glusterGeoRepKeysUpdate(String remoteUserName, List<String> geoRepPubKeys) { > Change to use remoteUserName as second parameter to this method Done Line 1204: JsonRpcRequest request = Line 1205: new RequestBuilder("Gluster.writeGeoRepPubKeys") Line 1206: .withParameter("geoRepPubKeys", geoRepPubKeys) Line 1207: .withOptionalParameter("userName", remoteUserName).build(); https://gerrit.ovirt.org/#/c/29833/23/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 278: GlusterServersListReturnForXmlRpc glusterServersList(); Line 279: Line 280: GlusterHostsPubKeyReturnForXmlRpc glusterGeoRepKeysGet(); Line 281: Line 282: StatusOnlyReturnForXmlRpc glusterGeoRepKeysUpdate(String remoteUserName, List<String> geoRepPubKeys); > change to remoteUserName as second paramater Done Line 283: Line 284: StatusOnlyReturnForXmlRpc glusterGeoRepMountBrokerSetup(String remoteVolumeName, String remoteUserName, String remoteGroupName); Line 285: Line 286: StatusOnlyReturnForXmlRpc glusterVolumeGeoRepSessionCreate(String volumeName, String remoteHost, String remoteVolumeName, String remoteUserName, Boolean force); -- To view, visit https://gerrit.ovirt.org/29833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
