Einav Cohen has posted comments on this change. Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297) ......................................................................
Patch Set 7: Verified; Looks good to me, approved Eventually, I would want the note-label to appear before the "approve operation" check-box, since I believe that it is more correct UX-wise: The user should first read all the relevant information, and only then make the decision [reading-flow-wise it is more correct]. However, this change should be applied to all places that contain a latch and a note; i.e. the correct place to do that is the RemoveConfirmationPopupView. So you made a good point - since this type of change will affect multiple views in the application, it is better to do it in a separate patch. [I rebased the patch and added "Note:" to the beginning of the label text] -- To view, visit http://gerrit.ovirt.org/7583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
