Einav Cohen has posted comments on this change.
Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297)
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 190:
Line 191: @DefaultStringValue("Detach Virtual Machine(s)")
Line 192: String detachVirtualMachinesTitle();
Line 193:
Line 194: @DefaultStringValue("You chose to detach all VMs from the pool -
this will remove the pool itself.")
message is ok, assuming the dialog contains the "are you sure" message
separately (as practically all confirmation dialogs in the application should).
Tomas - is this the case? Does the dialog contain *also* an "are you sure"
message?
Line 195: String detachAllVmsWarning();
Line 196:
Line 197: @DefaultStringValue("Permissions")
Line 198: String permissionsTitle();
--
To view, visit http://gerrit.ovirt.org/7583
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
