Tomas Jelinek has posted comments on this change. Change subject: webadmin: Edit pool hangs when the pool has no VMs (#852297) ......................................................................
Patch Set 6: Adding a "Note:" at the beginning is not a problem. However, moving the note before a check box and align it may be problematic, because I have used the standard RemoveConfirmationPopupPresenterWidget to render the "latch - e.g. checkbox" and the note (this is a standard way across the application how to do this). The design of the view of this dialog is therefore common across the application (for example detach of the local storage domain looks the same). So, I see three possibilities: - change the RemoveConfirmationPopupPresenterWidget (well, its view...) The whole application would look the same now and in the future - but it is a bit invasive change change - create a custom view to create a custom appearance. It is less invasive, but not consistent with the rest of the application - let it as it is :) What would you prefer? -- To view, visit http://gerrit.ovirt.org/7583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b8f47e6dd5ce8149ba78c7c25455997b3bf62eb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
