mooli tayer has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/37886/10/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 29: private List<String> defaults = new ArrayList<>(); Line 30: Line 31: private static final Properties defaultProperties = loadProperties(ParametersParser.class, "defaults.properties"); Line 32: Line 33: static enum ArgumentType { > this is part of standard terms, man getopt_long Is seems to be has_arg there which is also clearer Line 34: Line 35: required_argument("required_argument"), Line 36: optional_argument("optional_argument"), Line 37: no_argument("no_argument"); -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
