Roy Golan has posted comments on this change. Change subject: engine: On vm replacement vialidate vm Numa config match host Numa config ......................................................................
Patch Set 2: Code-Review-1 (1 comment) we should revisit the whole existence of the physical host Id in the vmNumaNode entity. if the vmNode is pinned, our reference should be always one, the pinned host (vm.dedicatedVmForVds) Gilad, other than UI is there a need for the physical host id in VmNumaNode? if the only reason its there is for ui I suggest to remove it and rewrite this whole patch https://gerrit.ovirt.org/#/c/38770/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java: Line 710: private boolean isReplacingNumaPinnedVm() { Line 711: Guid dedicatedVdsGuid = getVm().getDedicatedVmForVds(); Line 712: if (dedicatedVdsGuid == null) Line 713: return false; Line 714: // question for review: is it safe to assume vm run at least once prior to replacement? please make this comments. It looks part of the code and is very confusing Line 715: // question for review: Why getVm().getDynamicData().getLastVdsRunOn() not working - relevant db column is Line 716: // empty, shell we fix? Line 717: Line 718: // get dedicated host Numa nodes information -- To view, visit https://gerrit.ovirt.org/38770 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32c7fede611dd3d1d0efeaae41f57f8273b7e37 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
