mooli tayer has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/37886/10/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties.in File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/core/arguments.properties.in: Line 10: core.arg.log-file.name = log-file Line 11: core.arg.log-file.help = file where log will be stored Line 12: core.arg.log-file.type = required_argument Line 13: core.arg.log-level.name = log-level Line 14: core.arg.log-level.help = file where log will be stored logging level? Line 15: core.arg.log-level.type = required_argument Line 16: core.arg.log-level.convert = java.util.logging.Level Line 17: core.arg.log-level.default = INFO Line 18: core.arg.log-level.matcher = FINEST|FINER|FINE|CONFIG|INFO|WARNING|SEVERE|ALL https://gerrit.ovirt.org/#/c/37886/10/backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/services/arguments.properties.in File backend/manager/extension-tool/src/main/resources/org/ovirt/engine/exttool/logger/services/arguments.properties.in: Line 6: logrecord.arg.extension-name.mandatory = true Line 7: logrecord.arg.extension-name.type = required_argument Line 8: logrecord.arg.extension-name.help = name of logger extension Line 9: logrecord.arg.message.name = message Line 10: logrecord.arg.message.help = message which should be send to logger sent Line 11: logrecord.arg.message.type = required_argument Line 12: logrecord.arg.message.mandatory = true Line 13: logrecord.arg.level.name = level Line 14: logrecord.arg.level.help = level of log message to be send Line 10: logrecord.arg.message.help = message which should be send to logger Line 11: logrecord.arg.message.type = required_argument Line 12: logrecord.arg.message.mandatory = true Line 13: logrecord.arg.level.name = level Line 14: logrecord.arg.level.help = level of log message to be send "to send" or "to be sent" Line 15: logrecord.arg.level.type = required_argument Line 16: logrecord.arg.level.matcher = FINEST|FINER|FINE|CONFIG|INFO|WARNING|SEVERE Line 17: logrecord.arg.level.convert = java.util.logging.Level Line 18: logrecord.arg.level.default = INFO https://gerrit.ovirt.org/#/c/37886/10/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ParametersParser.java: Line 29: private List<String> defaults = new ArrayList<>(); Line 30: Line 31: private static final Properties defaultProperties = loadProperties(ParametersParser.class, "defaults.properties"); Line 32: Line 33: static enum ArgumentType { Regarding the naming of X.type = required_argument and static enum ArgumentType {...} consider naming X.value = required (required|mandatory|none) and static enum ValueType {...} accordingly. currently X.type = required_argument and X.mandatory are a little confusing. Line 34: Line 35: required_argument("required_argument"), Line 36: optional_argument("optional_argument"), Line 37: no_argument("no_argument"); -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
