Tal Nisan has posted comments on this change. Change subject: webadmin: Allow creation of new disks as copy of any existing disk ......................................................................
Patch Set 3: Code-Review+1 (1 comment) Looks ok basically, just a small comment https://gerrit.ovirt.org/#/c/38335/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java: Line 521: getChangeQuotaCommand()); Line 522: } Line 523: Line 524: private void updateCopyAndMoveCommandAvailability(List<Disk> disks) { Line 525: boolean isMoveAllowed = true; This change is quite redundant I'd say.. Line 526: boolean isCopyAllowed = true; Line 527: Line 528: if (disks == null || disks.isEmpty() || disks.get(0).getDiskStorageType() != DiskStorageType.IMAGE) { Line 529: disableMoveAndCopyCommands(); -- To view, visit https://gerrit.ovirt.org/38335 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c11478216a11d12208365ebdc69b9665766f6ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
