Alon Bar-Lev has posted comments on this change. Change subject: extensions test tool: logger ......................................................................
Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/37886/9/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 30: private static final String ARG_HELP = "help"; Line 31: Line 32: private static org.slf4j.Logger logger = LoggerFactory.getLogger(ExtensionsToolExecutor.class); Line 33: Line 34: public static void main(String[] args) { int exitStatus = 1; Line 35: try { Line 36: Map<String, Object> argMap = parseArgs(args); Line 37: setupLogger(argMap); Line 38: Line 60: } Line 61: Line 62: loadExtensions(moduleService, argMap); Line 63: moduleService.run(); Line 64: } catch(ArgumentException e) { ArgumentException suggests something bad :) Rename to ExitException or something similar and have an exit code as member. This class can be inner class of this one, no need to expose it. Line 65: System.out.println(e.getMessage()); Line 66: System.exit(0); Line 67: } catch (Throwable t) { Line 68: String message = t.getMessage() != null ? t.getMessage() : t.getClass().getName(); Line 62: loadExtensions(moduleService, argMap); Line 63: moduleService.run(); Line 64: } catch(ArgumentException e) { Line 65: System.out.println(e.getMessage()); Line 66: System.exit(0); exitStatus = e.getExitStatus(); Line 67: } catch (Throwable t) { Line 68: String message = t.getMessage() != null ? t.getMessage() : t.getClass().getName(); Line 69: logger.error(message); Line 70: logger.debug(message, t); Line 67: } catch (Throwable t) { Line 68: String message = t.getMessage() != null ? t.getMessage() : t.getClass().getName(); Line 69: logger.error(message); Line 70: logger.debug(message, t); Line 71: System.exit(1); remove Line 72: } Line 73: } Line 74: Line 75: private static void loadExtensions(ModuleService moduleService, Map<String, Object> argMap) { Line 68: String message = t.getMessage() != null ? t.getMessage() : t.getClass().getName(); Line 69: logger.error(message); Line 70: logger.debug(message, t); Line 71: System.exit(1); Line 72: } System.exit(exitStatus); Line 73: } Line 74: Line 75: private static void loadExtensions(ModuleService moduleService, Map<String, Object> argMap) { Line 76: ExtensionsManager extensionsManager = new ExtensionsManager(); -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
