Alon Bar-Lev has posted comments on this change.

Change subject: extensions test tool: logger
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/37886/7/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java
File 
backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java:

Line 97:     private static Map<String, ModuleService> loadModules(Class cls) {
Line 98:         Map<String, ModuleService> modules = new HashMap<>();
Line 99:         if(cls != null) {
Line 100:             Map<String, ExtensionProxy> proxies = new HashMap<>();
Line 101:             ExtMap context = new 
ExtMap().mput(Base.GlobalContextKeys.EXTENSIONS_MAP, proxies);
> I think I got lost too. In previous patchest you said it's better to have o
ok, so no reason to modify Base as this is private for your application and 
have nothing to do with the actual base of the API, you just use ExtMap 
privately.
Line 102: 
Line 103:             ServiceLoader<ModuleService> loader = 
ServiceLoader.load(cls);
Line 104:             for (ModuleService module : loader) {
Line 105:                 modules.put(module.getName(), module);


-- 
To view, visit https://gerrit.ovirt.org/37886
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com>
Gerrit-Reviewer: Ondřej Macháček <machacek.on...@gmail.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to